[webkit-reviews] review requested: [Bug 89197] [Chromium] Implements DeviceMotion : [Attachment 166015] Platform-based patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 27 09:17:06 PDT 2012


Hans Wennborg <hans at chromium.org> has asked  for review:
Bug 89197: [Chromium] Implements DeviceMotion
https://bugs.webkit.org/show_bug.cgi?id=89197

Attachment 166015: Platform-based patch
https://bugs.webkit.org/attachment.cgi?id=166015&action=review

------- Additional Comments from Hans Wennborg <hans at chromium.org>
Here is a stab at what a full-blown platform-based approach might look like.

This patch ignores the other ports, layout tests, hooking up in DRT, and
changelog - so I expect red EWS-bots - but it does work end-to-end in Chromium.


Please take a look at the patch and let me know if I understood correctly that
this is the kind of plumbing you had in mind, and I can go on to make it a
full-blown patch, update the other ports or ping their mantainers, etc.


More information about the webkit-reviews mailing list