[webkit-reviews] review denied: [Bug 97663] [BlackBerry] [DRT] Skip region of interest zooming when running DRT : [Attachment 165970] patch revision 1

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Xiaobo Wang
<xiaobo.wang at torchmobile.com.cn>'s request for review:
Bug 97663: [BlackBerry] [DRT] Skip region of interest zooming when running DRT
https://bugs.webkit.org/show_bug.cgi?id=97663

Attachment 165970: patch revision 1
https://bugs.webkit.org/attachment.cgi?id=165970&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=165970&action=review


Better to have isRunningDrt with a simpler implementation, looks good
otherwise.

> Source/WebKit/blackberry/Api/BlackBerryGlobal.cpp:164
> +#endif

I think this is overkill. Just calling getenv always should not be slow, and
anyway the final release will not even call it but just return false here.