[webkit-reviews] review granted: [Bug 97461] Web Inspector: NMI: move visited and countObjectSize methods implementation into separate class : [Attachment 165988] comments addressed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 27 06:41:53 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 97461: Web Inspector: NMI: move visited and countObjectSize methods
implementation into separate class
https://bugs.webkit.org/show_bug.cgi?id=97461

Attachment 165988: comments addressed
https://bugs.webkit.org/attachment.cgi?id=165988&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165988&action=review


> Source/WTF/wtf/MemoryInstrumentation.h:96
> +    MemoryInstrumentation(MemoryInstrumentationClient* client) :
m_client(client) { }

should be marked explicit

> Source/WebCore/inspector/MemoryInstrumentationImpl.cpp:67
> +void MemoryInstrumentationImpl::processDeferredInstrumentedPointers()

Why did this move?


More information about the webkit-reviews mailing list