[webkit-reviews] review granted: [Bug 97775] [Qt] Delay viewport position, scale and contents size updates until tiles are rendered : [Attachment 165982] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Jocelyn Turcotte
<jocelyn.turcotte at digia.com>'s request for review:
Bug 97775: [Qt] Delay viewport position, scale and contents size updates until
tiles are rendered
https://bugs.webkit.org/show_bug.cgi?id=97775

Attachment 165982: Patch
https://bugs.webkit.org/attachment.cgi?id=165982&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165982&action=review


Seems sane

> Source/WebKit2/ChangeLog:20
> +	   Since many of these updates happen during page load, all producing
an itterative adjustment

itte???

> Source/WebKit2/UIProcess/PageViewportController.cpp:131
> +    // avoid offseting our deferred position by scaling at the viewport
center.

offseting???

> Source/WebKit2/UIProcess/PageViewportController.cpp:132
> +    // All position and scale change resulting from a web process event
should

changes*