[webkit-reviews] review granted: [Bug 97751] webkitpy: make warning about missing BUG identifiers per-port configurable : [Attachment 165917] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 26 21:30:38 PDT 2012


Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 97751: webkitpy: make warning about missing BUG identifiers per-port
configurable
https://bugs.webkit.org/show_bug.cgi?id=97751

Attachment 165917: Patch
https://bugs.webkit.org/attachment.cgi?id=165917&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165917&action=review


Seems like a reasonable path forward.

> Tools/Scripts/webkitpy/layout_tests/port/base.py:1005
> +    def warn_if_bug_missing_in_test_expectations(self):
> +	   return False
> +

I assume this copy-paste was accidental?


More information about the webkit-reviews mailing list