[webkit-reviews] review requested: [Bug 97521] [Forms] Move multiple fields related functions to BaseDateAndTimeInputType from TimeInputType : [Attachment 165922] Patch 3
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 26 21:07:49 PDT 2012
yosin at chromium.org has asked for review:
Bug 97521: [Forms] Move multiple fields related functions to
BaseDateAndTimeInputType from TimeInputType
https://bugs.webkit.org/show_bug.cgi?id=97521
Attachment 165922: Patch 3
https://bugs.webkit.org/attachment.cgi?id=165922&action=review
------- Additional Comments from yosin at chromium.org
Could you review this patch?
Thanks in advance.
= Changes since the last review =
* Make BaseMultipleFieldsDateAndTimeInputType::formatDateTimeFieldsState() and
setupLayoutParameters() pure virtual
** Fix compilation error and no need to have default functions
* Update ChangeLog
More information about the webkit-reviews
mailing list