[webkit-reviews] review granted: [Bug 78595] CollectingRules and QueryingRules modes of SelectorChecker miss some complex selectors with pseudo elements : [Attachment 165740] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 78595: CollectingRules and QueryingRules modes of SelectorChecker miss some
complex selectors with pseudo elements
https://bugs.webkit.org/show_bug.cgi?id=78595

Attachment 165740: Patch
https://bugs.webkit.org/attachment.cgi?id=165740&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=165740&action=review


> Source/WebCore/ChangeLog:8
> +	   Do not use the same dynamicPseudo reference when recursively
invoking checkSelector() for non-SubSelector selectors.

Why does this work (or does it?) in ResolvingStyle case?

> Source/WebCore/css/SelectorChecker.cpp:476
> +    PseudoId nonSubSelectorPseudo(NOPSEUDO);
> +    PseudoId& currentDynamicPseudo = relation == CSSSelector::SubSelector ?
dynamicPseudo : nonSubSelectorPseudo;

That looks bit funny but I suppose it is ok.