[webkit-reviews] review granted: [Bug 96863] REGRESSION(r124168): Null crash in RenderLayer::createScrollbar : [Attachment 165688] Proposed fix: avoid triggering a style change if we only need a temporary style.

[bugzilla-daemon at webkit.org]

Abhishek Arya <inferno at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 96863: REGRESSION(r124168): Null crash in RenderLayer::createScrollbar
https://bugs.webkit.org/show_bug.cgi?id=96863

Attachment 165688: Proposed fix: avoid triggering a style change if we only
need a temporary style.
https://bugs.webkit.org/attachment.cgi?id=165688&action=review

------- Additional Comments from Abhishek Arya <inferno at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165688&action=review


> Source/WebCore/rendering/RenderObject.cpp:135
> +	   // RenderImageResource requires a style being present on the image
but we don't want to

typo s/RenderImageResource/RenderImageResourceStyleImage. i actually debugged
this to understand what is going on and can see the addClient call invoked
through RenderImageResourceStyleImage::initialize. Also please add a comment on
why this code with the "if (contentData && !contentData->next() &&
contentData->isImage() && doc != node)" not be moved to
RenderImage::styleDidChange ?

> LayoutTests/scrollbars/scrollbar-content-crash.html:12
> +function passed() {

'passed' sounds weird since the test might fail. How about something like
runTest.