[webkit-reviews] review denied: [Bug 94433] Add call stacks to Content Security Policy checks when relevant. : [Attachment 165847] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Mike West <mkwst at chromium.org>'s
request for review:
Bug 94433: Add call stacks to Content Security Policy checks when relevant.
https://bugs.webkit.org/show_bug.cgi?id=94433

Attachment 165847: Patch
https://bugs.webkit.org/attachment.cgi?id=165847&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165847&action=review


This is fine, but we don't what to have JSC types in WebCore headers.  That's
the problem that ScriptState.h is supposed to solve for us.

> Source/WebCore/page/ContentSecurityPolicy.h:44
> +#if USE(JSC)
> +namespace JSC {
> +class ExecState;
> +}
> +#endif

This shouldn't be needed.

> Source/WebCore/page/ContentSecurityPolicy.h:57
> +#if USE(JSC)
> +typedef JSC::ExecState ScriptState;
> +#else
> +class ScriptState;
> +#endif

Why not just include ScriptState.h ?