[webkit-reviews] review granted: [Bug 92669] [Qt] load event fires on XMLHttpRequestUpload twice with Qt5 : [Attachment 165836] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Marcelo Lira
<marcelo.lira at openbossa.org>'s request for review:
Bug 92669: [Qt] load event fires on XMLHttpRequestUpload twice with Qt5
https://bugs.webkit.org/show_bug.cgi?id=92669

Attachment 165836: Patch
https://bugs.webkit.org/attachment.cgi?id=165836&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165836&action=review


> Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:586
> +    if (!bytesTotal)
> +	   return;

I would add a comment

if (!bytesTotal) {
    // When finished QNetworkReply emits a progress of 0 bytes.
    // Ignore that, to avoid firing twice.
    return;
}