[webkit-reviews] review granted: [Bug 97609] DelayNode must take sample-accurate delay times into account : [Attachment 165691] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 97609: DelayNode must take sample-accurate delay times into account
https://bugs.webkit.org/show_bug.cgi?id=97609

Attachment 165691: Patch
https://bugs.webkit.org/attachment.cgi?id=165691&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=165691&action=review


Looks fine as far as I can tell. r=me. Would be nice to have a layout test.

> Source/WebCore/Modules/webaudio/DelayDSPKernel.cpp:116
> +	   delayTime = max(0.0, delayTime);

Would be nice to have a templatized "clamp" primitive somewhere.