[webkit-reviews] review granted: [Bug 97691] Add ability for JSArray::unshiftCount to unshift in middle of an array : [Attachment 165819] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 97691: Add ability for JSArray::unshiftCount to unshift in middle of an
array
https://bugs.webkit.org/show_bug.cgi?id=97691

Attachment 165819: Patch
https://bugs.webkit.org/attachment.cgi?id=165819&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=165819&action=review


> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:245
> -    if (!header && isJSArray(thisObj) &&
asArray(thisObj)->unshiftCount(exec, count))
> +    if (isJSArray(thisObj) && asArray(thisObj)->unshiftCount(exec, header,
count))

You'll have to rebase this against my recent bugfix to this line of code.