[webkit-reviews] review granted: [Bug 97401] [MathML] Implement <mtd> rowspan and columnspan attributes : [Attachment 165292] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dave Barton
<dbarton at mathscribe.com>'s request for review:
Bug 97401: [MathML] Implement <mtd> rowspan and columnspan attributes
https://bugs.webkit.org/show_bug.cgi?id=97401

Attachment 165292: Patch
https://bugs.webkit.org/attachment.cgi?id=165292&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165292&action=review


Well, I've certainly learned quite a bit in this thread.  I think we're
eventually going to want to share more code with HTMLTableElement, but I think
the code duplication is OK for this first-pass implementation.	(I don't think
I necessarily understand all the contraints of MathMLTable yet well enough to
decide what should or shouldn't be shared.)

> Source/WebCore/rendering/RenderTableCell.cpp:77
> +    if (UNLIKELY(!m_hasAssociatedTableCellElement)) {

I worry some callers might use this to imply that the table cell was anonymous.
 We have a "table cell" element associated, it's just not an HTML table cell.

colSpan() is actually surprisingly hot code. :)