[webkit-reviews] review granted: [Bug 97685] [chromium] Do not propagate touch-events to plugins unless they explicitly request for touch-events. : [Attachment 165808] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 26 10:32:49 PDT 2012
Adam Barth <abarth at webkit.org> has granted sadrul at chromium.org's request for
review:
Bug 97685: [chromium] Do not propagate touch-events to plugins unless they
explicitly request for touch-events.
https://bugs.webkit.org/show_bug.cgi?id=97685
Attachment 165808: Patch
https://bugs.webkit.org/attachment.cgi?id=165808&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
I mean, this patch is fine, but we really should be testing this stuff. We
don't have very many plugin test, especially for PPAPI plugins. I suspect
writing a test here is going to be a fair amount of work because I don't think
we have an API-level testing framework for plugins. That's something we should
add, but I feel mean blocking this two-line patch on creating that testing
framework.
More information about the webkit-reviews
mailing list