[webkit-reviews] review denied: [Bug 97689] [chromium][Android] Add WebSecurityPolicy::grantAccessToLocalFiles(bool) : [Attachment 165821] patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Ben Murdoch <benm at google.com>'s
request for review:
Bug 97689: [chromium][Android] Add
WebSecurityPolicy::grantAccessToLocalFiles(bool)
https://bugs.webkit.org/show_bug.cgi?id=97689

Attachment 165821: patch
https://bugs.webkit.org/attachment.cgi?id=165821&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165821&action=review


Do you really want to this globally for the whole process or just for an
individual WebView?

> Source/WebKit/chromium/public/WebSecurityPolicy.h:98
> +    // Grants access to file:// URLs.
> +    WEBKIT_EXPORT static void grantAccessToLocalFiles(bool);

Also, this boolean parameter is really vague.  Perhaps this should be two
functions, one that grants local access for all URIs and one that grants access
only for local URIs.