[webkit-reviews] review granted: [Bug 97688] [Chromium] Fix find-in-page corner case for detached frames : [Attachment 165813] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Leandro Graciá Gil
<leandrogracia at chromium.org>'s request for review:
Bug 97688: [Chromium] Fix find-in-page corner case for detached frames
https://bugs.webkit.org/show_bug.cgi?id=97688

Attachment 165813: Patch
https://bugs.webkit.org/attachment.cgi?id=165813&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165813&action=review


We really need better testing for this feature.  I don't want to hold up this
patch over lack of testing, but that's the reason we're having these sorts of
troubles.

> Source/WebKit/chromium/src/WebFrameImpl.cpp:1734
> -	   if (frame() && frame()->editor()->markedTextMatchesAreHighlighted())

> +	   if (frame() && frame->page() &&
frame()->editor()->markedTextMatchesAreHighlighted())

frame -> frame()