[webkit-reviews] review granted: [Bug 97617] (Threaded scrolling) WebKit not scrolling to the correct location upon going back on macsurfer.com : [Attachment 165718] Patch v3 - Now with more scroll events
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 26 08:43:22 PDT 2012
Anders Carlsson <andersca at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 97617: (Threaded scrolling) WebKit not scrolling to the correct location
upon going back on macsurfer.com
https://bugs.webkit.org/show_bug.cgi?id=97617
Attachment 165718: Patch v3 - Now with more scroll events
https://bugs.webkit.org/attachment.cgi?id=165718&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=165718&action=review
> Source/WebCore/page/scrolling/ScrollingTreeState.h:139
> + bool m_representsProgrammaticScroll;
How about m_scrollPositionRequestRepresentsProgrammaticScroll or
m_requestedScrollPositionRepresentsProgrammaticScroll to better indicate that
it goes with setRequestedScrollPosition?
Looks fine otherwise!
More information about the webkit-reviews
mailing list