[webkit-reviews] review denied: [Bug 97663] [BlackBerry] [DRT] Skip region of interest zooming when running DRT : [Attachment 165772] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 26 07:50:01 PDT 2012


Rob Buis <rwlbuis at gmail.com> has denied Xiaobo Wang
<xiaobo.wang at torchmobile.com.cn>'s request for review:
Bug 97663: [BlackBerry] [DRT] Skip region of interest zooming when running DRT
https://bugs.webkit.org/show_bug.cgi?id=97663

Attachment 165772: patch
https://bugs.webkit.org/attachment.cgi?id=165772&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=165772&action=review


R- because it can be done cleaner.

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1073
> +#endif

The fix itself is good. But can you make a helper method for this, and put it
in Api/BlackBerryGlobal? There is also one place in WebPage.cpp which does
something like the above, you can use the new function there too.


More information about the webkit-reviews mailing list