[webkit-reviews] review denied: [Bug 97633] [Forms] Adding localization texts for multiple fields date/time input UI : [Attachment 165762] Patch 4

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 97633: [Forms] Adding localization texts for multiple fields date/time
input UI
https://bugs.webkit.org/show_bug.cgi?id=97633

Attachment 165762: Patch 4
https://bugs.webkit.org/attachment.cgi?id=165762&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165762&action=review


> Source/WebKit/chromium/ChangeLog:15
> +	   (WebCore::dateFormatHelpLetters): Added for DateInputType,
DateTimeInputType, and DateTimeLocalInputType to provide three letters, e.g.
"ymd" for English, for indicating order of day, month and year fields to
display them intead of "-" when field has empty value. Each letter should have
same width to "-" in monospace font-family. This function may return empty
string if there are no such letters in locale or order of day, month and year
is well-known in locale.

This doesn't resolve my previous question.  is a sequence of 'A' and U+0300
(COMBINING GRAVE ACCENT) one letter?  Why don't you support at most two letters
for one field though a day/month/year field has at least two digits?

BTW, these explanation should be in LocalizedStrings.h and WebCore/ChangeLog,
not WebKit/chromium/ChangeLog.

> Source/WebKit/chromium/ChangeLog:16
> +	   (WebCore::dateFormatHelpText): Added for DateInputType,
DateTimeInputType, and DateTimeLocalInputType to provide help text of order of
day, month and year fields, e.g. "Day/Month/Year". This string will be
displayed bubble when the input element is focused and dateFormatHelpLetters()
returns empty string. This function may return empty string if order of day,
month, and year is well-known in locale.

We already have WebCore::localizedDateFormatText().  Also, a date format
depends on a local machine setting, and we need some code to build this text. 
Such text is not suitable for LocalizedStrings.