[webkit-reviews] review denied: [Bug 97633] [Forms] Adding localization texts for multiple fields date/time input UI : [Attachment 165739] Patch 1

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 97633: [Forms] Adding localization texts for multiple fields date/time
input UI
https://bugs.webkit.org/show_bug.cgi?id=97633

Attachment 165739: Patch 1
https://bugs.webkit.org/attachment.cgi?id=165739&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165739&action=review


> Source/WebCore/ChangeLog:16
> +	   Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name

> +	   to support "date", "datetime", "month" and "week" multiple fields
input
> +	   UI.

Why don't you rename it before this patch?

> Source/WebCore/ChangeLog:22
> +	   (WebCore): Added declarations of dateFormatHelpLetters(),
dateFormatHelpText(), monthFormatInLDML() and
> +	   weekFormatInLDML().

Because we have no call sites of these functions yet, none except you can
understand what the functions should return.
Please explain what they are and why they are needed concretely.