[webkit-reviews] review granted: [Bug 97579] Web Inspector: Fix logging in pure protocol test harness : [Attachment 165646] Patch for most of platforms

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 25 22:48:03 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has granted Peter Rybin
<prybin at chromium.org>'s request for review:
Bug 97579: Web Inspector: Fix logging in pure protocol test harness
https://bugs.webkit.org/show_bug.cgi?id=97579

Attachment 165646: Patch for most of platforms
https://bugs.webkit.org/attachment.cgi?id=165646&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165646&action=review


> LayoutTests/http/tests/inspector-protocol/resources/protocol-test.js:33
> +    alert(text);

console.log() should also print a message to stdout in the tests but it would
add messages to the inspector which might be undesirable in some protocol
tests, so I guess alert should be fine here.


More information about the webkit-reviews mailing list