[webkit-reviews] review denied: [Bug 97551] Add tests for datalist UI for input type date : [Attachment 165595] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 97551: Add tests for datalist UI for input type date
https://bugs.webkit.org/show_bug.cgi?id=97551

Attachment 165595: Patch
https://bugs.webkit.org/attachment.cgi?id=165595&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165595&action=review


>
LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-appearance
.html:25
> +    <option label="-">2012-01-21</option>

What's the intention of this label="-"?

>
LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-appearance
.html:74
> +    <option>2012-03-08</option>
> +    <option>2012-01-00</option> <!--invalid-->
> +    <option>foo</option> <!--invalid-->

* I don't think we need such large number of options in this test. 20 + a few
would be enough.
* Invalid options should be younger children in order to check whether they are
omitted or not.