[webkit-reviews] review denied: [Bug 89742] [Win] key event's location does not work on Windows platform. : [Attachment 162416] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 89742: [Win] key event's location does not work on Windows platform.
https://bugs.webkit.org/show_bug.cgi?id=89742

Attachment 162416: Patch
https://bugs.webkit.org/attachment.cgi?id=162416&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162416&action=review


r- due to style issues.

> Source/WebCore/ChangeLog:9
> +	   Additional information of the change such as approach, rationale.
Pleas	     As WM_KEYDOWN, WM_KEYUP, WM_SYSKEYDOWN, and WM_SYSKEYUP doesn't
> +	   directly provide a virtual keycode which distinguish between
left-hand

These two lines of changelogs are messed up.

> Source/WebCore/platform/win/KeyEventWin.cpp:189
> +static int windowsKeycodeWithLocation(WPARAM wparam, LPARAM lparam)

It's better to give these argument variable more descriptive names like
keycode.

> Source/WebCore/platform/win/KeyEventWin.cpp:196
> +    // 24bit: Indicates whether the key is an extended key, such as
> +    // the right-hand ALT and CTRL keys.

This is quite obvious from the code.

> Source/WebCore/platform/win/KeyEventWin.cpp:197
> +    // However, if we don't need to support WindowsXP or older Windows,

Nit: Windows XP.