[webkit-reviews] review denied: [Bug 97539] Broken and incorrect code in FastMalloc.cpp : [Attachment 165565] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 25 11:19:32 PDT 2012


Alexey Proskuryakov <ap at webkit.org> has denied Mark Toller
<mark.toller at samsung.com>'s request for review:
Bug 97539: Broken and incorrect code in FastMalloc.cpp
https://bugs.webkit.org/show_bug.cgi?id=97539

Attachment 165565: Patch
https://bugs.webkit.org/attachment.cgi?id=165565&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I think that this code should be:

-    ASSERT(pthread_mutex_trylock(m_scavengeMutex));
+    ASSERT(!pthread_mutex_trylock(&m_scavengeMutex));

Does such an assert make more sense?


More information about the webkit-reviews mailing list