[webkit-reviews] review granted: [Bug 97572] [GTK] Enable some of the unstable CSS features : [Attachment 165636] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 25 10:22:22 PDT 2012
Martin Robinson <mrobinson at webkit.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 97572: [GTK] Enable some of the unstable CSS features
https://bugs.webkit.org/show_bug.cgi?id=97572
Attachment 165636: Patch
https://bugs.webkit.org/attachment.cgi?id=165636&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165636&action=review
>> Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h:122
>> + static void setStyleScopedEnabled(bool enabled);
>
> The parameter name "enabled" adds no information, so it should be removed.
[readability/parameter_name] [5]
Please fix this before landing.
More information about the webkit-reviews
mailing list