[webkit-reviews] review granted: [Bug 97563] GIFImageReader: fix tautological compare : [Attachment 165601] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Hans Wennborg <hans at chromium.org>'s
request for review:
Bug 97563: GIFImageReader: fix tautological compare
https://bugs.webkit.org/show_bug.cgi?id=97563

Attachment 165601: Patch
https://bugs.webkit.org/attachment.cgi?id=165601&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165601&action=review


>>> Source/WebCore/ChangeLog:15
>>> +	     value in the enum.
>> 
>> Is there any observable consequence of this change?	If so, should we write
a test?
> 
> There's no observable difference.
> 
> The code currently relied on unspecified behavior (i.e. that the enum can
represent more values than it strictly has to), and my change just fixes that.

Ah, I see.  We have storage for all the bits, they're just outside the enum
range.	Makes sense.