[webkit-reviews] review denied: [Bug 97406] Measure the usage of window.webkitURL in the hopes of dropping support completely. : [Attachment 165284] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Mike West <mkwst at chromium.org>'s
request for review:
Bug 97406: Measure the usage of window.webkitURL in the hopes of dropping
support completely.
https://bugs.webkit.org/show_bug.cgi?id=97406

Attachment 165284: Patch
https://bugs.webkit.org/attachment.cgi?id=165284&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165284&action=review


>>> Source/WebCore/page/DOMWindow.idl:788
>>> +	     attribute [Conditional=BLOB, V8MeasureAs=PrefixedWindowURL]
DOMURLConstructor webkitURL; // FIXME: deprecate this.
>> 
>> You might want to check the generated code.	I think V8MeasureAs isn't smart
enough to work with constructors because we batch-configure the constructors
rather than generating actual bindings code for them.
> 
> Hrm. You're right.
> 
> I started to fiddle with adding some smarts to the batch configuration code
by adding a measurement flag to BatchedAttribute, but it dives into V8 via
setAttribute, and that gets ugly fast. :/
> 
> Do you have a suggestion for an alternate approach?

Yeah, that's why I didn't implement it in the first patch.  :)

This is tricky because there isn't any code to instrument!  We could make this
property custom.  Then it wouldn't be batch-configured and we'd have some code
that we could add a call to FeatureObserver in...