[webkit-reviews] review granted: [Bug 97540] MediaStream API: Update getUserMedia to match the latest specification : [Attachment 165564] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 97540: MediaStream API: Update getUserMedia to match the latest
specification
https://bugs.webkit.org/show_bug.cgi?id=97540

Attachment 165564: Patch
https://bugs.webkit.org/attachment.cgi?id=165564&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165564&action=review


> Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:59
> +	   bool flag = false;

flag = ?  I guess the name ok is already taken...

> Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:83
> +    RefPtr<UserMediaRequest> request = adoptRef(new
UserMediaRequest(context, controller, audio.release(), video.release(),
successCallback, errorCallback));
> +
>      return request.release();

You can merge these lines and delete the variable |request| if you like.

> Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:102
> +    return (bool)m_audio;

static_cast<bool>(m_audio)

WebKit uses C++ style casts.

Actually, is that even necessary?  Does the compiler complain if you leave off
the explicit cast?