[webkit-reviews] review granted: [Bug 97538] CSP paths: Ignore invalid path components, rather than dropping the source completely. : [Attachment 165557] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Mike West <mkwst at chromium.org>'s
request for review:
Bug 97538: CSP paths: Ignore invalid path components, rather than dropping the
source completely.
https://bugs.webkit.org/show_bug.cgi?id=97538

Attachment 165557: Patch
https://bugs.webkit.org/attachment.cgi?id=165557&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165557&action=review


> Source/WebCore/page/ContentSecurityPolicy.cpp:1579
> +{

Can you ASSERT that invalidChar is either '#' or '?'

I know you have that assert above, but it's good to have it in this function
because the correctness of this function depends on that fact.