[webkit-reviews] review denied: [Bug 90017] [Meta] [Shadow] contenteditable attribute for distributed nodes. : [Attachment 161609] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 90017: [Meta] [Shadow] contenteditable attribute for distributed nodes.
https://bugs.webkit.org/show_bug.cgi?id=90017

Attachment 161609: Patch
https://bugs.webkit.org/attachment.cgi?id=161609&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161609&action=review


>>> Source/WebCore/css/StyleResolver.cpp:1783
>>> +	 if (m_distributedToInsertionPoint) {
>> 
>> This seems like an odd place for this code. Should this not be in
StyleResolver::applyProperty?
> 
> In StyleResolver::applyProperty, I found that "case
CSSPropertyWebkitUserModify:" is "ASSERT_NOT_REACHED();"
> So did you mean StyleBuilder.cpp? i.e. adding a new class, e.g.
ApplyPropertyUserModify and implementing an original applyInheritValue?

Yep, that seems like the more logical approach.