[webkit-reviews] review denied: [Bug 97120] Web Inspector: yellow on-hover pop-up won't go if another pane asynchronously opens : [Attachment 165619] New patch update

[bugzilla-daemon at webkit.org]

Alexander Pavlov (apavlov) <apavlov at chromium.org> has denied Mirela
<mbudaes at adobe.com>'s request for review:
Bug 97120: Web Inspector: yellow on-hover pop-up won't go if another pane
asynchronously opens
https://bugs.webkit.org/show_bug.cgi?id=97120

Attachment 165619: New patch update
https://bugs.webkit.org/attachment.cgi?id=165619&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165619&action=review


Two small nits to fix, and the patch will be ready to land

> Source/WebCore/inspector/front-end/Popover.js:244
> +	       && event.relatedTarget !== null

WebKit coding style guidelines require that null/0/undefined/whatever checks be
performed by casting to a bool (e.g. ... && event.relatedTarget && ...) unless
we need to disambiguate the actual value (e.g. null vs. undefined vs. "" vs. 0)
- see http://www.webkit.org/coding/coding-style.html#zero-comparison

> Source/WebCore/inspector/front-end/Popover.js:246
> +	   if (event.target === this._hoverElement || isPopoverMouseOut )

Extraneous whitespace before ')'