[webkit-reviews] review denied: [Bug 97120] Web Inspector: yellow on-hover pop-up won't go if another pane asynchronously opens : [Attachment 165556] Update the patch based on the review.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 25 04:27:49 PDT 2012


Alexander Pavlov (apavlov) <apavlov at chromium.org> has denied Mirela
<mbudaes at adobe.com>'s request for review:
Bug 97120: Web Inspector: yellow on-hover pop-up won't go if another pane
asynchronously opens
https://bugs.webkit.org/show_bug.cgi?id=97120

Attachment 165556: Update the patch based on the review.
https://bugs.webkit.org/attachment.cgi?id=165556&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165556&action=review


> Source/WebCore/ChangeLog:3
> +	   Fix for bug 97210

Hmm, please remove this auto-generated line...

> Source/WebCore/inspector/front-end/Popover.js:242
> +	   if (event.target === this._hoverElement || (this.isPopoverVisible()
&& !event.relatedTarget.isSelfOrDescendant(this._popover._contentDiv)))

Please check event.relatedTarget for null-ity to avoid throwing a JS exception.


More information about the webkit-reviews mailing list