[webkit-reviews] review granted: [Bug 97517] REGRESSION(r129448): multiple fields time input UI doesn't use system time format settings on Chromium-Mac : [Attachment 165518] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 97517: REGRESSION(r129448): multiple fields time input UI doesn't use
system time format settings on Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=97517

Attachment 165518: Patch
https://bugs.webkit.org/attachment.cgi?id=165518&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165518&action=review


>> Source/WebCore/platform/text/mac/LocaleMac.mm:55
>> +	return normalizedLocale.left(separatorPosition);
> 
> Is it OK to compare only language part?
> 
> It seems that short date format for en_CA and en_US are different.
> 
> CA yy-MM-dd
> GB dd/MM/yyyy
> 
>
http://unicode.org/cldr/trac/browser/tags/release-21-0-1/common/main/en_CA.xml
>
http://unicode.org/cldr/trac/browser/tags/release-21-0-1/common/main/en_GB.xml
> 
> Should we have another bug to fix this?

Yeah, It should be a separated issue.