[webkit-reviews] review canceled: [Bug 97120] Web Inspector: yellow on-hover pop-up won't go if another pane asynchronously opens : [Attachment 165388] Add mouseout event listener on popover element.

[bugzilla-daemon at webkit.org]

Alexander Pavlov (apavlov) <apavlov at chromium.org> has canceled Mirela
<mbudaes at adobe.com>'s request for review:
Bug 97120: Web Inspector: yellow on-hover pop-up won't go if another pane
asynchronously opens
https://bugs.webkit.org/show_bug.cgi?id=97120

Attachment 165388: Add mouseout event listener on popover element.
https://bugs.webkit.org/attachment.cgi?id=165388&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165388&action=review


> Source/WebCore/ChangeLog:3
> +	   Fix for bug 97210

Please remove this auto-added line

> Source/WebCore/inspector/front-end/Popover.js:242
> +	   if (event.target === this._hoverElement || 

WebKit has no limit for the line length, so the entire condition can be placed
on a single line. And we definitely do not observe closing parentheses on a
separate line.

> Source/WebCore/inspector/front-end/Popover.js:243
> +	       (this.isPopoverVisible() &&
!event.toElement.isSelfOrDescendant(this._popover._contentDiv))

IIRC, event.toElement can be null/undefined if you are moving the pointer
outside the browser window quickly (which is confirmed by
http://trac.webkit.org/browser/trunk/Source/WebCore/dom/MouseEvent.cpp#L137).
Also, "toElement" is an MSIE extension. The spec'ed way is
"event.relatedTarget".