[webkit-reviews] review granted: [Bug 96650] Web Inspector: move Vector memory instrumentation from core NMI code to MemoryInstrumentationVector.h : [Attachment 165140] with fixes for mac and elf.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 24 23:23:44 PDT 2012


Vsevolod Vlasov <vsevik at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 96650: Web Inspector: move Vector memory instrumentation from core NMI code
to MemoryInstrumentationVector.h
https://bugs.webkit.org/show_bug.cgi?id=96650

Attachment 165140: with fixes for mac and elf.
https://bugs.webkit.org/attachment.cgi?id=165140&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165140&action=review


> Source/WTF/wtf/MemoryInstrumentationVector.h:48
> +template<size_t inlineCapacity> void
instrumentVectorValues(MemoryClassInfo&, const Vector<char*, inlineCapacity>*
const&) { }

Is this char* special case handler always correct?


More information about the webkit-reviews mailing list