[webkit-reviews] review requested: [Bug 17427] Line breaking opportunities at the end of a text node are missed : [Attachment 165510] Proposed patch v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 24 21:02:04 PDT 2012


Alex Henrie <alexhenrie24 at gmail.com> has asked	for review:
Bug 17427: Line breaking opportunities at the end of a text node are missed
https://bugs.webkit.org/show_bug.cgi?id=17427

Attachment 165510: Proposed patch v3
https://bugs.webkit.org/attachment.cgi?id=165510&action=review

------- Additional Comments from Alex Henrie <alexhenrie24 at gmail.com>
Try 3. I used a StringBuilder this time, and made the code only concatenate the
context together once for an entire set of runs. This works quite nicely. I
tried a few different ways and finally settled on using a hash table to
determine where each text node lies in the context string. I'll email Michael
Saboff to ask what would have to be done to change this code to use UText
instead of StringBuilder, but I think this patch would be fine as-is.


More information about the webkit-reviews mailing list