[webkit-reviews] review denied: [Bug 95376] Dromaeo jquery DOM modification tests run out of memory and crash in current WebKit : [Attachment 165072] Fixes the bug

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has denied Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 95376: Dromaeo jquery DOM modification tests run out of memory and crash in
current WebKit
https://bugs.webkit.org/show_bug.cgi?id=95376

Attachment 165072: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=165072&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=165072&action=review


>>
PerformanceTests/Dromaeo/resources/dromaeo/web/tests/jslib-modify-jquery.html:3
2
>> +	var runs = 0;
> 
> Line contains tab character.	[whitespace/tab] [5]

Setting 0 here doesn't make sense. test() queues the given function up and run
it later.
See weberunner.js.

I would add an optional parameter to specify the cleanup function.