[webkit-reviews] review granted: [Bug 97386] Fix Geolocation error reporting in the test support : [Attachment 165440] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 24 15:07:14 PDT 2012


Sam Weinig <sam at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 97386: Fix Geolocation error reporting in the test support
https://bugs.webkit.org/show_bug.cgi?id=97386

Attachment 165440: Patch
https://bugs.webkit.org/attachment.cgi?id=165440&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165440&action=review


r=me

> Source/WebKit/chromium/public/WebGeolocationClientMock.h:52
> -    WEBKIT_EXPORT void setError(int errorCode, const WebString& message);
> +    WEBKIT_EXPORT void setPositionUnavailableError(const WebString&
message);

I am not sure if you are supposed to change this.


More information about the webkit-reviews mailing list