[webkit-reviews] review granted: [Bug 96156] [CSS Exclusions] ExclusionShape API should use logical coordinates for input/output : [Attachment 165413] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 96156: [CSS Exclusions] ExclusionShape API should use logical coordinates
for input/output
https://bugs.webkit.org/show_bug.cgi?id=96156

Attachment 165413: Patch
https://bugs.webkit.org/attachment.cgi?id=165413&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
To be honest, I am not very happy that you don't store the FloatRect and
FloatSize values in the Exclusion* classes. That would look a lot cleaner IMO.
However, at this point it might be over engineering to prepare the code for
that.