[webkit-reviews] review denied: [Bug 97475] Replace RenderMeter::updateLogicalHeight to RenderMeter::computeLogicalHeight : [Attachment 165434] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied Tony Chang <tony at chromium.org>'s
request for review:
Bug 97475: Replace RenderMeter::updateLogicalHeight to
RenderMeter::computeLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=97475

Attachment 165434: Patch
https://bugs.webkit.org/attachment.cgi?id=165434&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165434&action=review


> Source/WebCore/rendering/RenderMeter.cpp:71
> +    LayoutRect frame = frameRect();
> +    if (isHorizontalWritingMode())
> +	   frame.setHeight(computedValues.m_extent);
> +    else
> +	   frame.setWidth(computedValues.m_extent);

Dead code?