[webkit-reviews] review granted: [Bug 97426] Unexpected reftest passes are only reported when pixel testing is enabled in results.html as well : [Attachment 165408] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 97426: Unexpected reftest passes are only reported when pixel testing is
enabled in results.html as well
https://bugs.webkit.org/show_bug.cgi?id=97426

Attachment 165408: Patch
https://bugs.webkit.org/attachment.cgi?id=165408&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165408&action=review


This is a nice cleanup. Would be great if you addressed my one comment, but I
understand if you'd rather just add a FIXME and commit this.

> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:174
> +	   if '==' in result.reftest_type:
> +	       test_dict['is_reftest'] = True
> +	   if '!=' in result.reftest_type:
> +	       test_dict['is_mismatch_reftest'] = True

How about just putting reftest_type in test_dict directly and changing
results.html to look at that? You can make this a FIXME if you don't want to do
it now.