[webkit-reviews] review denied: [Bug 91382] Web Inspector: Comment/uncomment line(s) by pressing Cmd + / : [Attachment 165135] Proposed bug fix. Replaced Cmd + / from Pause script to Toggle code comment.

[bugzilla-daemon at webkit.org]

Andrey Adaikin <aandrey at chromium.org> has denied Mihai Balan
<mibalan at adobe.com>'s request for review:
Bug 91382: Web Inspector: Comment/uncomment line(s) by pressing Cmd + /
https://bugs.webkit.org/show_bug.cgi?id=91382

Attachment 165135: Proposed bug fix. Replaced Cmd + / from Pause script to
Toggle code comment.
https://bugs.webkit.org/attachment.cgi?id=165135&action=review

------- Additional Comments from Andrey Adaikin <aandrey at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165135&action=review


> Source/WebCore/inspector/front-end/DefaultTextEditor.js:1594
> +	       if (line.match(commentRegEx)) {

this will not work for multiple lines with comments:

var a = 1;
// a comment
var b = 2;

will become:

// var a = 1;
a comment
// var b = 2;

while should be:

// var a = 1;
// // a comment
// var b = 2;

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:1606
> +    },

return true;