[webkit-reviews] review canceled: [Bug 96763] Web Inspector: CSS property names autocomplete: Suggest most used rather than alphabeticaly first : [Attachment 164998] Implement selection of non-first item in WebInspector.TextPrompt.SuggestBox

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 24 09:33:40 PDT 2012


Nikita Vasilyev <me at elv1s.ru> has canceled Nikita Vasilyev <me at elv1s.ru>'s
request for review:
Bug 96763: Web Inspector: CSS property names autocomplete: Suggest most used
rather than alphabeticaly first
https://bugs.webkit.org/show_bug.cgi?id=96763

Attachment 164998: Implement selection of non-first item in
WebInspector.TextPrompt.SuggestBox
https://bugs.webkit.org/attachment.cgi?id=164998&action=review

------- Additional Comments from Nikita Vasilyev <me at elv1s.ru>
> >> Source/WebCore/inspector/front-end/TextPrompt.js:1151
> >> +	      var fragment = document.createDocumentFragment();
> > 
> > Is using DocumentFragment any faster than the direct modification of
element's children in this case?
> 
> I should guarantee a single repaint.

I did some profiling: it does a single repaint in both cases and there is no
performance deviation between them (takes 1–4ms on my machine). Therefor I keep
it as it was.


More information about the webkit-reviews mailing list