[webkit-reviews] review granted: [Bug 96999] Web Inspector: [Styles] For group selectors, transmit their segments with the "matches" flag : [Attachment 165334] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 24 09:28:33 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 96999: Web Inspector: [Styles] For group selectors, transmit their segments
with the "matches" flag
https://bugs.webkit.org/show_bug.cgi?id=96999

Attachment 165334: Patch
https://bugs.webkit.org/attachment.cgi?id=165334&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165334&action=review


> Source/WebCore/inspector/Inspector.json:2013
> +		       { "name": "matches", "type": "array", "items": { "$ref":
"RuleMatch" }, "description": "Matches of CSS rules applicable to the pseudo
style."}

Rename the group to PseudoIdMatches ?

> Source/WebCore/inspector/Inspector.json:2031
> +		       { "name": "matchingIndices", "type": "array", "items": {
"type": "integer" }, "description": "Matching selector indices in the rule's
selectorList selectors (0-based)." }

matchingSelectors


More information about the webkit-reviews mailing list