[webkit-reviews] review denied: [Bug 93473] Web Inspector: The front-end should provide the position in original source file when set a breakpoint : [Attachment 161964] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Peter Wang
<peter.wang at torchmobile.com.cn>'s request for review:
Bug 93473: Web Inspector: The front-end should provide the position in original
source file when set a breakpoint
https://bugs.webkit.org/show_bug.cgi?id=93473

Attachment 161964: Patch
https://bugs.webkit.org/attachment.cgi?id=161964&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161964&action=review


Can you provide a test for this?

> Source/WebCore/bindings/js/ScriptDebugServer.cpp:144
> +	   m_lastExecutedLine = lineNumber;

has* methods should not modify the object, this is why in particular it was
marked const.

> Source/WebCore/bindings/js/ScriptDebugServer.cpp:162
> +	   // Since frontend truncates the indent, so the first statement in a
line must matches the breakpoint (line, 0).

typo: Since frontend truncates the indent, the first statement in a line must
match the breakpoint