[webkit-reviews] review denied: [Bug 95341] Web Inspector: The JS code injected by worker inspector shouldn't be evaluated through JSMainThreadExecState : [Attachment 165344] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 24 08:26:30 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has denied Peter Wang
<peter.wang at torchmobile.com.cn>'s request for review:
Bug 95341: Web Inspector:  The JS code injected by worker inspector shouldn't
be evaluated through JSMainThreadExecState
https://bugs.webkit.org/show_bug.cgi?id=95341

Attachment 165344: Patch
https://bugs.webkit.org/attachment.cgi?id=165344&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165344&action=review


> Source/WebCore/inspector/InjectedScriptManager.h:87
> +    bool m_isForWorker;

You don't seem to need this field. Please remove.


More information about the webkit-reviews mailing list