[webkit-reviews] review requested: [Bug 90968] [NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW : [Attachment 165331] draft patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 24 01:53:43 PDT 2012


János Badics <jbadics at inf.u-szeged.hu> has asked  for review:
Bug 90968: [NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW
https://bugs.webkit.org/show_bug.cgi?id=90968

Attachment 165331: draft patch
https://bugs.webkit.org/attachment.cgi?id=165331&action=review

------- Additional Comments from János Badics <jbadics at inf.u-szeged.hu>
Made modifications suggested by Peter Gal.
But while correcting, I noticed that it only solves the pboblem with DRT; WTR
still stops testing after 30 seconds, even though
WebKitTestRunner/qt/TestControllerQt.cpp::platformRunUntil uses 60 seconds
timeout in its while loop. The counter never reaches that 60000 because
something stops the testing after 30 seconds. At the moment, I couldn't tell
what causes the stop, but I'm on it. Any help is appreciated.


More information about the webkit-reviews mailing list