[webkit-reviews] review granted: [Bug 97416] PutScopedVar should not be marked as clobbering the world : [Attachment 165297] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 23 17:13:39 PDT 2012


Filip Pizlo <fpizlo at apple.com> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 97416: PutScopedVar should not be marked as clobbering the world
https://bugs.webkit.org/show_bug.cgi?id=97416

Attachment 165297: Patch
https://bugs.webkit.org/attachment.cgi?id=165297&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
I think you've already covered your bases, but before landing I would go
through the cases in CSE one more time and make sure that nothing has slipped
by.  In your case, you're probably fine since we don't inline PutScopedVar, and
we never have PutScopedVar on *this frame's* locals, and I don't think we do
any CSE on resolve's.


More information about the webkit-reviews mailing list