[webkit-reviews] review granted: [Bug 73767] [GTK] Implement GraphicsLayer using Clutter : [Attachment 165285] Martin & Carlos, thanks for the review

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Joone Hur
<joone at webkit.org>'s request for review:
Bug 73767: [GTK] Implement GraphicsLayer using Clutter
https://bugs.webkit.org/show_bug.cgi?id=73767

Attachment 165285: Martin & Carlos, thanks for the review
https://bugs.webkit.org/attachment.cgi?id=165285&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165285&action=review


> Source/WebCore/platform/graphics/clutter/PlatformClutterLayerClient.h:39
> +#include <glib.h>
> +#include <wtf/HashMap.h>
> +#include <wtf/PassRefPtr.h>
> +#include <wtf/RefCounted.h>
> +#include <wtf/Vector.h>
> +#include <wtf/text/StringHash.h>

It seems some of these aren't necessary. Maybe you could remove them before
landing?

> Source/WebCore/platform/graphics/clutter/TransformationMatrixClutter.cpp:34
> +    matrix.xx = static_cast<float>(m11());
> +    matrix.xy = static_cast<float>(m21());
> +    matrix.xz = static_cast<float>(m31());
> +    matrix.xw = static_cast<float>(m41());

I'm really not sure if these explicit casts are necessary...

I created this small program on my machine:
#include <stdio.h>

int main(int argc, char* argv[])
{
    double foo = 3.4;
    float bar;
    bar = foo;
    printf("bar: %f\n", bar);
    return 0;
}

and compiled it with g++ -Wall. I didn't see any warnings. Will you please try
to remove them before landing?