[webkit-reviews] review denied: [Bug 97306] Fix build warnings : -Wunused-parameter, -Wparentheses, -Wuninitialized. : [Attachment 165274] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Byungwoo Lee
<bw80.lee at samsung.com>'s request for review:
Bug 97306: Fix build warnings : -Wunused-parameter, -Wparentheses,
-Wuninitialized.
https://bugs.webkit.org/show_bug.cgi?id=97306

Attachment 165274: Patch
https://bugs.webkit.org/attachment.cgi?id=165274&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165274&action=review


> Source/JavaScriptCore/heap/MachineStackMarker.cpp:101
>  static void pthreadSignalHandlerSuspendResume(int signo)
>  {
> +    UNUSED_PARAM(signo);

You should remove the parameter name in this case.

> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:306
>  static SlowPathReturnType entryOSR(ExecState* exec, Instruction* pc,
CodeBlock* codeBlock, const char *name, EntryKind kind)
>  {
> +    UNUSED_PARAM(pc);

Can't you remove the parameter entirely?
If not, remove the name.

> Source/JavaScriptCore/runtime/DatePrototype.cpp:201
>  static JSCell* formatLocaleDate(ExecState* exec, DateInstance* dateObject,
double timeInMilliseconds, LocaleDateTimeFormat format)
>  {
> +    UNUSED_PARAM(dateObject);
>      UDateFormatStyle timeStyle = (format != LocaleDate ? UDAT_LONG :
UDAT_NONE);

Remove the parameter name.

> Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp:273
> +    UNUSED_PARAM(mimeType);
>      ASSERT(mimeType == "image/png"); // Only PNG output is supported for
now.

This should be ASSERT_UNUSED

> Source/WebCore/platform/image-decoders/ImageDecoder.h:294
> +	       UNUSED_PARAM(profileLength);
>	       ASSERT(profileLength >= iccColorProfileHeaderLength);

Ditto.

> Source/WebCore/platform/image-decoders/ImageDecoder.h:302
> +	       UNUSED_PARAM(profileLength);
>	       ASSERT(profileLength >= iccColorProfileHeaderLength);

Ditto.

> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:661
> +    UNUSED_PARAM(iconType);

Ditto.

> Source/WebKit2/Platform/CoreIPC/Connection.cpp:430
> +    UNUSED_PARAM(syncRequestID);

Remove syncRequestID.

> Source/WebKit2/UIProcess/API/cpp/efl/WKEinaSharedString.cpp:64
> +    UNUSED_PARAM(adoptTag);
>      ASSERT(adoptTag == AdoptWK); // Guard for future enum changes.

ASSERT_UNUSED.

> Source/WebKit2/UIProcess/API/cpp/efl/WKEinaSharedString.cpp:76
> +    UNUSED_PARAM(adoptTag);
>      ASSERT(adoptTag == AdoptWK); // Guard for future enum changes.

Ditto.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2799
>  {
> +    UNUSED_PARAM(frame);
>      ASSERT(frame->isMainFrame());

Ditto.